Skip to content

Packages the repository with uv#78

Merged
louislelay merged 11 commits intomainfrom
feat/uv-install
Dec 12, 2025
Merged

Packages the repository with uv#78
louislelay merged 11 commits intomainfrom
feat/uv-install

Conversation

@louislelay
Copy link
Collaborator

@louislelay louislelay commented Dec 12, 2025

Refactors the whole repository to become a uv powered package. It makes it easier to use the repository and to maintain.

#76
#75

@louislelay louislelay merged commit 6919ed7 into main Dec 12, 2025
@louislelay louislelay deleted the feat/uv-install branch December 12, 2025 14:08
@louislelay
Copy link
Collaborator Author

Fixed #73

Hi @vic-w and @d-kleine, could you tell me if everything works on your end?

@d-kleine
Copy link

d-kleine commented Dec 12, 2025

I am a Windows user, therefore unfortunately I cannot test the IsaacLab features powered by uv, see isaac-sim/IsaacLab#3438

Great work so far – I only have some smaller observations regarding the uv changes:

  • License missing in pyproject.yaml
  • Description blank in pyproject.yaml
  • "Clone the repository." section has wrong information in README

@louislelay
Copy link
Collaborator Author

louislelay commented Dec 12, 2025

I'm not using what they do, it's independant and I actually wanted to test it on Windows to see if it could work, so let's see with your machine if it could work!

And good catch, I'll update!

@d-kleine
Copy link

There is still path issue here:

import isaac_so_arm101.tasks  # noqa: F401
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named 'isaac_so_arm101'

Affects multiple files due to the refactoring

@louislelay
Copy link
Collaborator Author

what were you running?

@d-kleine
Copy link

d-kleine commented Dec 12, 2025

Nevermind, I didn't see that you also restructured the repo.


Just tested, up to uv run list_envs it worked so far. Running uv run train --task SO-ARM100-Reach-v0 --headless isn't possible due to the windows/uv issue, but with train --task SO-ARM100-Reach-v0 --headless this error was returned:

gymnasium.error.NameNotFound: Environment `SO-ARM100-Reach` doesn't exist. Did you mean: `Isaac-SO-ARM100-Reach`?

This is needs to be fixed in the README (dummy agents and reaching tasks):
https://github.com/MuammerBay/isaac_so_arm101?tab=readme-ov-file#reaching

@d-kleine
Copy link

My app crashes when running the correct task. I think this is due to dependency conflicts. I have checked that with uv pip check:

Checked 187 packages in 58ms
Found 4 incompatibilities
The package `isaacsim-core` requires `filelock==3.13.1`, but `3.15.4` is installed
The package `isaacsim-core` requires `fsspec==2024.6.1`, but `2024.10.0` is installed
The package `isaacsim-core` requires `networkx==3.3`, but `3.4.2` is installed
The package `isaacsim-core` requires `pywin32==306`, but `311` is installed

@d-kleine
Copy link

I have used my primary IsaacLab (pre-built binary installation), this works for uv run train --task Isaac-SO-ARM100-Reach-v0

@louislelay
Copy link
Collaborator Author

louislelay commented Dec 12, 2025

True, I forgot to update the task ID!

I'll try to check tonight on a windows installation of my own then, it is weird that uv run list_envs work but not uv run train --task My-Task-Id

Could you try to clone the repository in a completely different location with no virtual environment activated etc and run

uv run zero_agent --task Isaac-SO-ARM100-Reach-v0 --headless --num_envs 1

@d-kleine
Copy link

d-kleine commented Dec 12, 2025

it is weird that uv run list_envs work but not uv run train --task My-Task-Id

uv run list_envs outputs the env table correct, but also returns some error messages:

TypeError: post_quit(): incompatible function arguments. The following argument types are supported:
    1. (self: omni.kit.app._app.IApp, return_code: int = 0) -> None

This also supports my assumption that the venv is broken (your pyproject.toml setup looks fine though)

@d-kleine
Copy link

Is there a reason why you have used this unsafe strategy?

index-strategy = "unsafe-best-match"

@louislelay
Copy link
Collaborator Author

for convenience as i have multiple packages index configured!

@d-kleine
Copy link

d-kleine commented Dec 15, 2025

Okay 👌🏻

So, regarding the uv changes, everything's fine from my point-of-view. Only the tasks need to be updated in the README.

@louislelay
Copy link
Collaborator Author

I said it in another issue but if you want to do the PR for the task ID naming, I'd be glad to accept it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants